[Location Sharing]: Pin drop location sharing #5957
Conversation
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kn5pYZ |
| switch userLocationAnnotation.coordinateType { | ||
| case .user: | ||
| self.addUserMarkerView(with: userLocationAnnotation.avatarData) | ||
| case .pin, .generic: |
There was a problem hiding this comment.
Can be interesting to create a PinLocationAnnotation and init(pinLocationAnnotation: PinLocationAnnotation)
| @@ -19,14 +19,23 @@ import SwiftUI | |||
| import Combine | |||
| import CoreLocation | |||
|
|
|||
| // This is the equivalent of MXEventAssetType in the MatrixSDK | |||
| enum LocationSharingCoordinateType { | |||
There was a problem hiding this comment.
You can make just 2 cases in the app side. case pin, case user. As you will not handle generic case in your screens.
|
|
||
| self.coordinate = coordinate | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
You have to create the intermediate class PinLocationAnnotation: LocationAnnotation. UserLocationAnnotation can be casted as LocationAnnotation and if we add a new kind of annotation like POIAnnotation we will not be able to distinct them.
Requires matrix-org/matrix-ios-sdk#1428
Fix: #5858
Light theme:
Dark theme:
