Room activity indicators #5690
Merged
Room activity indicators #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/sJrTGQ |
This was referenced Feb 24, 2022
amshakal
approved these changes
Feb 24, 2022
Signed-off-by: Andy Uhnak <[email protected]>
Anderas
force-pushed
the
andy/5603_room_indicators
branch
from
5d56120 to
6386566
Compare
|
One note; i think it looks a bit awkward together with the Unread pill, but in general i think this addresses part of #4614 I'll have to see and feel this in action before i can say this fully addresses it though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5603
Each time I added indicators to a new screen, I encounter different challenges and architectures across the app, which forced me to change the shape of the API:
AppNavigatorand instead placed them intoTabBarCoordinatorandSplitViewCoordinator, because those are actually the views that typically display the indiciators, and are already close-enough toRoomCoordinator. The idea of a global / shared presenter is quite complicated, because there isn't always one guaranteed navigation controller available and setupPlaceholderViewControllerthat actually gets replaced. To show toasts instead requires having a navigationController with navigationBar (to anchor the toast correctly) and this is by no means easy, because a view controller does not actually yet havenavigationControllerby the time ofviewDidLoad. To solve this the room is not being injected with indicator presenter, which uses split views's detail router to show the indicator. This means we can show the spinner even before theRoomViewControlleris on screen and the placeholder is showing instead.UserIndicatorTypeto simplify the creation of the interactors. The enum can be extended in the future based on need.