Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "kick" by "remove" in all strings #5563

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

MaximeEvrard42
Copy link
Contributor

Fix #5346

Replace "kick" and all derivative by "remove"

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

Simulator Screen Shot - iPhone 8 Plus - 2022-02-11 at 14 34 56

Simulator Screen Shot - iPhone 8 Plus - 2022-02-11 at 14 36 14

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3kwMJN

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@MaximeEvrard42 MaximeEvrard42 merged commit b68574c into develop Feb 14, 2022
@MaximeEvrard42 MaximeEvrard42 deleted the maximee/5346_replace_kick_wording branch February 14, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "X kicked X" terminology when removing people from a room
2 participants