Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash uploading video ipad #5400

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

langleyd
Copy link
Member

@langleyd langleyd commented Jan 18, 2022

Fixes #5399

iPads show popovers rather than alert views and you need to specify the source of the popover so that it knows how to position/orientate itself.

@langleyd langleyd self-assigned this Jan 18, 2022
@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GcioPi

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@langleyd langleyd merged commit 0be2787 into develop Jan 19, 2022
@langleyd langleyd deleted the langleyd/5399_fix_crash_uploading_video_ipad branch January 19, 2022 09:19
@pixlwave
Copy link
Member

iPads show popovers rather than alert views and you need to specify the source of the popover so that it knows how to position/orientate itself.

Sorry, my bad I missed this. Thanks for the fix 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix crash when you upload a video on iPad when "Confirm size when sending" is enabled in settings
3 participants