Invite to space in room landing #5316
Conversation
- Added participant invite coordinator
- add share invite link to contacts screen - Fixed regression
- List of Space members with search - Invite interactions - Join room from list - Implement add room button, with rough edge warning.
- Implemented FAB for Home screen
- space menu additions according to new requirements
# Conflicts: # Riot/Modules/Room/RoomCoordinator.swift
- added room option bottom sheet
- UI tweaks for members and explore rooms screens
- UI tweaks for members and explore rooms screens
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/S8XqAr |
There was a problem hiding this comment.
Works as expected, thanks.
My only comment is starting the invite modal with the search on focus makes it a bit harder when you have no local contacts enabled, but I expect that to be the minority of users who are managing spaces.
@gileluard can we confirm that, if you don't have the permissions to add someone to a space, you don't get this binary choice sheet?
…n_room_landing # Conflicts: # Riot/Generated/Strings.swift # Riot/Modules/Room/Members/RoomParticipantsViewController.m # Riot/Modules/Spaces/SpaceMembers/MemberList/SpaceMemberListViewController.swift # Riot/Modules/Spaces/SpaceRoomList/ExploreRoom/SpaceExploreRoomViewController.swift # Riot/SupportingFiles/Riot-Bridging-Header.h
- Check user permissions to invite people
…n_room_landing # Conflicts: # Riot/Assets/en.lproj/Vector.strings # Riot/Generated/Images.swift # Riot/Generated/Strings.swift
- update after design review
- Added change logs
There was a problem hiding this comment.
Nice! Looking forward to all these changes to Spaces landing on iOS 😎
Some comments inline, otherwise it would helpful to have more doc comments e.g. I wasn't sure completely what AddItemHeaderView did to begin with until I saw it being used in a couple of places.
Riot/Modules/Room/ParticipantsInviteModal/ContactsPicker/ContactsPickerCoordinatorType.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Room/ParticipantsInviteModal/ContactsPicker/ContactsPickerViewModel.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Room/ParticipantsInviteModal/ContactsPicker/ContactsPickerViewModel.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Room/ParticipantsInviteModal/ContactsPicker/ContactsPickerViewModel.swift
Show resolved
Hide resolved
...les/Room/ParticipantsInviteModal/RoomParticipantsInviteModalCoordinatorBridgePresenter.swift
Outdated
Show resolved
Hide resolved
…ctsPickerViewModel.swift Co-authored-by: Doug <[email protected]>
…teModalCoordinatorBridgePresenter.swift Co-authored-by: Doug <[email protected]>
Co-authored-by: Doug <[email protected]>
Co-authored-by: Doug <[email protected]>
…nviteViewController.swift Co-authored-by: Doug <[email protected]>
Co-authored-by: Doug <[email protected]>
- Update after review
- Update after review
fix #5225, fix #5226, fix #5227
test build: https://i.diawi.com/MPjVq8
