Fix warnings in Contacts module #4681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
commented
Aug 9, 2021
| @@ -196,21 +196,24 @@ - (void)searchWithPattern:(NSString *)searchText forceReset:(BOOL)forceRefresh h | |||
| [hsUserDirectoryOperation cancel]; | |||
| hsUserDirectoryOperation = nil; | |||
| } | |||
|
|
|||
| MXWeakify(self); | |||
There was a problem hiding this comment.
Is weakifying and strongifying the right thing to do in this case as the request could have a longer lifetime than the data source which is holding a strong reference to it?
There was a problem hiding this comment.
I think it's okay. MXStrongifyAndReturnIfNil will return if the dataSource has been released in the meantime.
pixlwave
commented
Aug 9, 2021
| { | ||
| return; | ||
| } | ||
| MXStrongifyAndReturnIfNil(self); |
There was a problem hiding this comment.
It seems to me a Weakify/Strongify would have the same effect here, but flagging in case it doesn't.
stefanceriu
approved these changes
Aug 10, 2021
| @@ -196,21 +196,24 @@ - (void)searchWithPattern:(NSString *)searchText forceReset:(BOOL)forceRefresh h | |||
| [hsUserDirectoryOperation cancel]; | |||
| hsUserDirectoryOperation = nil; | |||
| } | |||
|
|
|||
| MXWeakify(self); | |||
There was a problem hiding this comment.
I think it's okay. MXStrongifyAndReturnIfNil will return if the dataSource has been released in the meantime.
| { | ||
| return; | ||
| } | ||
| MXStrongifyAndReturnIfNil(self); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4677.