Dark Theme - Bug Fix/Improvements #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebViewViewController extends MXKWebViewViewController to handle customization.
Add a top view in pickers (country, language) to display the right background in case of vertical bounce.
Recents Cell drag&drop: force the background color of the dragged cell.
Customize the device info pop-up
HTML string rendering: Use the grayscale component of the secondary bg color to set the background color in the default CSS
Force the background of the default view controller displayed in landscape when no room is selected.
Handle correctly the status bar display when the current view controller is presented in a temporary navigation controller.
Room settings: the wrong color is used for some check box labels.
Customize correctly the encryption info views
Recents List: some room avatars have an unexpected black background. We apply here the new property `defaultBackgroundColor` defined in MXKImageView class to initialize correctly image background.
Room preview - The sub-header has a wrong background color.
Customize correctly the event details views
Wrong sub-title color in section header after a UI theme change.
Force the background color of the fake view controller displayed when there is no details.
manuroe
reviewed
Aug 16, 2017
Riot/Utils/EventFormatter.m
Outdated
| @@ -69,6 +69,20 @@ - (instancetype)initWithMatrixSession:(MXSession *)matrixSession | |||
|
|
|||
| localTimeZone = [NSTimeZone localTimeZone]; | |||
|
|
|||
| CGFloat white = 1.0; | |||
| [kRiotSecondaryBgColor getWhite:&white alpha:nil]; | |||
There was a problem hiding this comment.
Why not getting the full RGB color value ([MXKTools rgbValueWithColor"])?
| [super viewDidLoad]; | ||
|
|
||
| // Observe user interface theme change. | ||
| kRiotDesignValuesDidChangeThemeNotificationObserver = [[NSNotificationCenter defaultCenter] addObserverForName:kRiotDesignValuesDidChangeThemeNotification object:nil queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *notif) { |
There was a problem hiding this comment.
How is kRiotDesignValuesDidChangeThemeNotificationObserver released?
manuroe
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebViewViewController extends MXKWebViewViewController to handle customization.