Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting existing rooms to/from DMs #715

Closed
giomfo opened this issue Oct 13, 2016 · 4 comments
Closed

Converting existing rooms to/from DMs #715

giomfo opened this issue Oct 13, 2016 · 4 comments
Assignees
@jeangb
Labels
auto-test-required feature P1 T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Milestone
sprint4

Comments

@giomfo
Copy link
Member

giomfo commented Oct 13, 2016 •
edited
Loading

The ability to untag a 1:1 room and make it a normal room.
Add a checkbox in RoomSettings.

Showing DMs them in the UI (as little green men).

Related to element-hq/element-web#2099
@giomfo giomfo added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements feature P1 labels Oct 13, 2016
@giomfo giomfo added this to the sprint4 milestone Oct 13, 2016
@giomfo
Copy link
Member Author

giomfo commented Oct 14, 2016 •
edited
Loading

More important is actually using the new DM semantics:

@giomfo giomfo mentioned this issue Oct 14, 2016
Closed
@giomfo giomfo self-assigned this Oct 17, 2016
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Oct 17, 2016
@giomfo
Converting existing rooms to/from DMs
14d085f 
element-hq/element-ios#715

MXRestClient: support `m.direct` event in `account_data` at session level.
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Oct 17, 2016
@giomfo
Converting existing rooms to/from DMs
8a08fe3 
element-hq/element-ios#715

MXKRecentListViewController: observe kMXSessionDirectRoomsDidChangeNotification notification
(reload the recents table view by default).
giomfo added a commit that referenced this issue Oct 17, 2016
@giomfo
Converting existing rooms to/from DMs #715
3eee79e 
Showing DMs in the UI (as little green men).
This was referenced Oct 18, 2016
Merged
Merged
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Oct 19, 2016
@giomfo
Converting existing rooms to/from DMs
8406215 
element-hq/element-ios#715

MXRestClient: support m.direct event in account_data at session level.
giomfo added a commit that referenced this issue Oct 19, 2016
@giomfo
Converting existing rooms to/from DMs
1e13c83 
#715

Showing DMs in the UI (as little green men).
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Oct 19, 2016
@giomfo
Converting existing rooms to/from DMs
b3b5d29 
element-hq/element-ios#715

MXRestClient: support m.direct event in account_data at session level.
giomfo added a commit that referenced this issue Oct 19, 2016
@giomfo
Merge pull request #730 from vector-im/vector_715
678143f 
Converting existing rooms to/from DMs #715
giomfo added a commit that referenced this issue Oct 21, 2016
@giomfo
Converting existing rooms to/from DMs
2ec885b 
#715

Add ability to tag/untag direct rooms in Messages screen.
@giomfo giomfo mentioned this issue Oct 21, 2016
Merged
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Nov 2, 2016
@giomfo
Feature - Converting existing rooms to/from DMs
ed9b973 
element-hq/element-ios#715

- Room creation: When the flag isDirect is turned on, only one user id is expected in the inviteArray. The room will be considered as direct only for the first mentioned user in case of several user ids.
giomfo added a commit that referenced this issue Nov 2, 2016
@giomfo
Feature - Converting existing rooms to/from DMs
6d7335d 
#715

- 'Start chat' in the Member Details page should instead list the rooms you have in common with the user, as per vector-web.
This was referenced Nov 2, 2016
Merged
Merged
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Nov 2, 2016
@giomfo
Feature - Converting existing rooms to/from DMs
7b96a32 
element-hq/element-ios#715

Ensure 1:1 rooms are created with equal ops on both sides (the trusted_private_chat preset)
@giomfo giomfo mentioned this issue Nov 2, 2016
Merged
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Nov 2, 2016
@giomfo
Feature - Converting existing rooms to/from DMs
b12c6b4 
element-hq/element-ios#715

Ensure 1:1 rooms are created with equal ops on both sides (the trusted_private_chat preset)
@giomfo giomfo mentioned this issue Nov 2, 2016
Merged
giomfo added a commit that referenced this issue Nov 2, 2016
@giomfo
Feature - Converting existing rooms to/from DMs
f74a384 
#715

Ensure 1:1 rooms are created with equal ops on both sides (the trusted_private_chat preset)
@giomfo giomfo mentioned this issue Nov 2, 2016
Merged
giomfo added a commit that referenced this issue Nov 2, 2016
@giomfo
Feature - Converting existing rooms to/from DMs
3f1a3bd 
#715

- If there is already a DM for the user, we should reuse it when hitting 'start chat'.
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Nov 2, 2016
@giomfo
Feature - Converting existing rooms to/from DMs
2df114e 
element-hq/element-ios#715

Ensure 1:1 rooms are created with equal ops on both sides (the trusted_private_chat preset)
Update SDK tests
This was referenced Nov 3, 2016
Open
Open
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Nov 3, 2016
@giomfo
Converting existing rooms to/from DMs
c8ad247 
element-hq/element-ios#715

Remove `privateOneToOneRoomWithUserId:` and `privateOneToOneUsers` (the developer must use the `directRooms` property instread).
@giomfo giomfo mentioned this issue Nov 3, 2016
Merged
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Nov 3, 2016
@giomfo
Converting existing rooms to/from DMs
516b08e 
element-hq/element-ios#715

Apply MatrixSDK changes (matrix-org/matrix-ios-sdk#158): Remove privateOneToOneRoomWithUserId: and privateOneToOneUsers (the developer must use the directRooms property instread).
@giomfo giomfo mentioned this issue Nov 3, 2016
Merged
giomfo added a commit that referenced this issue Nov 3, 2016
@giomfo
Converting existing rooms to/from DMs
c8dcf56 
#715

Apply MatrixSDK changes (matrix-org/matrix-ios-sdk#158): Remove privateOneToOneRoomWithUserId: and privateOneToOneUsers (the developer must use the directRooms property instread).
@giomfo giomfo mentioned this issue Nov 3, 2016
Merged
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Nov 3, 2016
@giomfo
Converting existing rooms to/from DMs
8108e36 
element-hq/element-ios#715

Add `directJoinedRoomWithUserId:` API: returns the first joined direct chat listed in account data for this user.
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Nov 3, 2016
@giomfo
Converting existing rooms to/from DMs
b19a936 
element-hq/element-ios#715

Use the added `directJoinedRoomWithUserId:` in MXSession API: returns the first joined direct chat listed in account data for this user.
giomfo added a commit that referenced this issue Nov 3, 2016
@giomfo
Converting existing rooms to/from DMs
58769b1 
#715

Use the new method added in MXSession API `directJoinedRoomWithUserId:`: returns the first joined direct chat listed in account data for this user.
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Nov 4, 2016
@giomfo
Converting existing rooms to/from DMs
44a2787 
element-hq/element-ios#715

MXKContactManager: `MXKContactManagerMXRoomSourceOneToOne` is renamed `MXKContactManagerMXRoomSourceDirectChats`.
@giomfo
Copy link
Member Author

giomfo commented Nov 4, 2016

Fixed, 2 issues have been created for the remaining points (#748 and #749).

@giomfo giomfo assigned jeangb and unassigned giomfo Nov 4, 2016
@jeangb
Copy link

jeangb commented Nov 14, 2016

@giomfo you said "Add a checkbox in RoomSettings." Are you talking about the room item context menu from the rooms list or the details view of a room ?

@jeangb
Copy link

jeangb commented Nov 14, 2016 •
edited
Loading

@giomfo about the checkbox

'Start chat' in the Member Details page should instead list the rooms you have in common with the user, as per vector-web.

We still have to display the "+ Start new chat" item right ?

@jeangb jeangb closed this as completed Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeangb jeangb

Labels
auto-test-required feature P1 T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
sprint4
Development

No branches or pull requests
2 participants
@giomfo @jeangb