-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace camera implementation with something more standard and less limited. #638
Comments
rotation meta fails if the phone is rotationlocked (unlike the native camera control) |
We really should ditch our custom camera control in favour of something which plays well with the latest features and hardware, especially with the iPhone X round the corner. |
Current balance: 0.0 ETH |
Cool, I'm on it. @ara4n anything I should know? I know my way around swift and git flow, but new to the crypto world and status. |
Hi @GreyEcologist, you have to fork see https://github.com/vector-im/riot-ios/blob/master/CONTRIBUTING.rst for more details |
Is a Swift implementation of this bounty considered acceptable? |
Is this bounty over? |
@oriyentel no, I regret a Swift implementation is not acceptable here. We don't want to mix the codebase. |
I have created a native camera much like snapchats in obj-c for Jumpvue. I can do this for you guys |
@giomfo I submitted a PR for this but I do not know how to assign reviewers. I do not have a drop down by the reviewers or assignees sidebar. Are we suppose to assign these to you or do you just pick them up? |
Hi @giomfo, I submitted a PR for this a couple weeks ago. Could I get some feedback on it please? |
ping |
Hi @knocte: we are waiting for @ianscott313 's feedbacks |
Hey guys sorry i haven't wrapped this up yet |
Status on the last PR and this bounty? |
Hi @debragail the bounty is still available. About the requirement you are free to kill our custom camera implementation or at least provide the normal one as an option. A Swift implementation is now acceptable. |
Doesn't handle rotation metadata, doesn't let me zoom or focus etc, doesn't let me take photos by pressing volume buttons. We need to ditch it in favour of the native controls or use a camera library of some kind
The text was updated successfully, but these errors were encountered: