Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace camera implementation with something more standard and less limited. #638

Closed
ara4n opened this issue Sep 16, 2016 · 17 comments
Closed
Labels
bounty feature P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone

Comments

@ara4n
Copy link
Member

ara4n commented Sep 16, 2016

Doesn't handle rotation metadata, doesn't let me zoom or focus etc, doesn't let me take photos by pressing volume buttons. We need to ditch it in favour of the native controls or use a camera library of some kind

@ara4n
Copy link
Member Author

ara4n commented Sep 16, 2016

rotation meta fails if the phone is rotationlocked (unlike the native camera control)

@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems feature P1 labels Sep 19, 2016
@giomfo giomfo modified the milestone: sprint4 Oct 13, 2016
@giomfo giomfo modified the milestones: sprint4, spring7 Oct 5, 2017
@ara4n ara4n changed the title Camera has some major limitations Replace camera implementation with something more standard and less limited. Oct 29, 2017
@ara4n
Copy link
Member Author

ara4n commented Oct 29, 2017

We really should ditch our custom camera control in favour of something which plays well with the latest features and hardware, especially with the iPhone X round the corner.

@status-open-bounty
Copy link

status-open-bounty commented Dec 12, 2017

Current balance: 0.0 ETH
Tokens: SNT: 10000.00
Contract address: 0x48c1e238ba885f133325f4a2fdb3025778df6f95
QR Code
Network: Mainnet
To claim this bounty sign up at https://openbounty.status.im and make sure to update your Ethereum address in My Payment Details so that the bounty is correctly allocated.
To fund it, send ETH or ERC20/ERC223 tokens to the contract address.

@GreyEcologist
Copy link

Cool, I'm on it. @ara4n anything I should know?

I know my way around swift and git flow, but new to the crypto world and status.

@GreyEcologist
Copy link

@ara4n @giomfo I branched off develop locally, but can't push my branch onto remote to create a Pull Request. I think you might have to add me to your organization so I can push my changes and create a PR.

Let me know how you want to proceed.

@giomfo
Copy link
Member

giomfo commented Dec 19, 2017

Hi @GreyEcologist, you have to fork riot-ios in your account.

see https://github.com/vector-im/riot-ios/blob/master/CONTRIBUTING.rst for more details

@im-jersh
Copy link

im-jersh commented Jan 4, 2018

Is a Swift implementation of this bounty considered acceptable?

@hrishinext
Copy link

Is this bounty over?

@giomfo
Copy link
Member

giomfo commented Jan 8, 2018

@oriyentel no, I regret a Swift implementation is not acceptable here. We don't want to mix the codebase.

@ianscott313
Copy link

I have created a native camera much like snapchats in obj-c for Jumpvue. I can do this for you guys

ianscott313 added a commit to ianscott313/riot-ios that referenced this issue Jan 25, 2018
@ianscott313
Copy link

@giomfo I submitted a PR for this but I do not know how to assign reviewers. I do not have a drop down by the reviewers or assignees sidebar. Are we suppose to assign these to you or do you just pick them up?

@ianscott313
Copy link

Hi @giomfo, I submitted a PR for this a couple weeks ago. Could I get some feedback on it please?

@knocte
Copy link

knocte commented Apr 15, 2018

ping

@giomfo
Copy link
Member

giomfo commented Apr 17, 2018

Hi @knocte: we are waiting for @ianscott313 's feedbacks

@ianscott313
Copy link

Hey guys sorry i haven't wrapped this up yet

@debragail
Copy link

Status on the last PR and this bounty?

@giomfo
Copy link
Member

giomfo commented Sep 10, 2018

Hi @debragail the bounty is still available.
Feel free to submit a PR (The existing one has never been updated according to the requested changes).

About the requirement you are free to kill our custom camera implementation or at least provide the normal one as an option.

A Swift implementation is now acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty feature P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.