Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Files component iOS #5372

Closed
daniellekirkwood opened this issue Jan 11, 2022 · 3 comments · Fixed by #6345
Closed

Update Files component iOS #5372

daniellekirkwood opened this issue Jan 11, 2022 · 3 comments · Fixed by #6345
Assignees
@gileluard @amshakal
Labels
A-Message-Bubbles Message Bubbles appearance in the Timeline parity-with-android parity-with-web T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team Z-Labs Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Jan 11, 2022 •
edited
Loading

Your use case

Update the "File" message type component to be the same as Web.

This issue is related to the Android issue: element-hq/element-android#4897

Files today Web today
Polls Android Bubbles Screenshot 2022-01-10 at 18 21 42

This was raised as part of the Bubbles work, but should apply to all Appearance layouts

Have you considered any alternatives?

No response

Additional context

No response
@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team A-Message-Bubbles Message Bubbles appearance in the Timeline labels Jan 11, 2022
@daniellekirkwood daniellekirkwood mentioned this issue Jan 11, 2022
Closed
@daniellekirkwood daniellekirkwood added parity-with-android parity-with-web Z-WTF WTF issues: High impact, Low Effort labels Jan 11, 2022
@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Feb 2, 2022
@github-actions github-actions bot added the Z-Labs label Feb 2, 2022
@daniellekirkwood daniellekirkwood mentioned this issue Feb 7, 2022
Closed
@daniellekirkwood daniellekirkwood changed the title Update Files component Update Files component iOS Feb 7, 2022
@amshakal
Copy link

amshakal commented Feb 7, 2022

Find design for files here: https://www.figma.com/file/zVtAKK0hzKu5JkpbzlE1pG/Message-Bubbles?node-id=1919%3A41337

@gileluard gileluard self-assigned this Jun 23, 2022
@gileluard
Copy link
Contributor

@amshakal

Here is what I managed to do (file and voice messages):

Image

Image

Image

Image

Is it ok for you?

@amshakal
Copy link

Looks good to me. Thanks Gil!

@gileluard gileluard mentioned this issue Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

@amshakal amshakal

Labels
A-Message-Bubbles Message Bubbles appearance in the Timeline parity-with-android parity-with-web T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team Z-Labs Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Files component iOS element-hq/element-ios
3 participants
@gileluard @amshakal @daniellekirkwood