Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Files component Android #4897

Closed
daniellekirkwood opened this issue Jan 10, 2022 · 4 comments
Closed

Update Files component Android #4897

daniellekirkwood opened this issue Jan 10, 2022 · 4 comments
Assignees
Labels
A-Message-Bubbles Message Bubbles appearance in the Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team Z-Labs Z-parity-with-web Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Jan 10, 2022

Your use case

Update the "File" message type component to be the same as Web

related to: element-hq/element-ios#5372

Android today Web today
Polls Android Bubbles Screenshot 2022-01-10 at 18 21 42

This was raised as part of the Bubbles work, and will be completed inside of the Bubbles project but should apply to all Appearance layouts

@daniellekirkwood daniellekirkwood added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jan 10, 2022
@daniellekirkwood daniellekirkwood added the A-Message-Bubbles Message Bubbles appearance in the Timeline label Jan 10, 2022
@daniellekirkwood
Copy link
Contributor Author

@amshakal @gaelledel or @janogarcia

I know you're looking at parity of components and across platforms. Would one of you be able to link the figma file so that the Android team can implement the right thing to match web?

@amshakal
Copy link

Hi yes, I think the plan is to make them look similar on all platforms. Link to figma for all media components: https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=2039%3A26421

Link for how they look in bubbles layout with timestamp inside the component: https://www.figma.com/file/zVtAKK0hzKu5JkpbzlE1pG/Message-Bubbles?node-id=1919%3A41337

@ganfra
Copy link
Member

ganfra commented Jan 14, 2022

On Android it handles the case where it's already downloaded to avoid doing it again. So there is different icons following the state. But will update so we have the pill and the rounded background.

@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Feb 2, 2022
@github-actions github-actions bot added the Z-Labs label Feb 2, 2022
@daniellekirkwood daniellekirkwood changed the title Update Files component Update Files component Android Feb 7, 2022
@daniellekirkwood
Copy link
Contributor Author

@ganfra What's the status of this issue? It's marked a couple of different ways in the different project boards and I know you're rolling off bubbles this sprint...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Message-Bubbles Message Bubbles appearance in the Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team Z-Labs Z-parity-with-web Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Development

No branches or pull requests

3 participants