Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Access-Token as header instead of query param #2071

Closed
manuroe opened this issue Oct 8, 2018 · 0 comments
Closed

Send Access-Token as header instead of query param #2071

manuroe opened this issue Oct 8, 2018 · 0 comments
Labels
P2 parity-with-android parity-with-web T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Milestone
Sprint 14

Comments

@manuroe
Copy link
Member

manuroe commented Oct 8, 2018

To do not have the access token in the query param (and accidentally have that in the logs when logging the query) and make use of header compression (on http2)

PR on android: matrix-org/matrix-android-sdk#251
@manuroe manuroe added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements P2 parity-with-web parity-with-android labels Oct 8, 2018
@manuroe manuroe added this to the Sprint 14 milestone Oct 8, 2018
@manuroe manuroe mentioned this issue Oct 8, 2018
Closed
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Oct 8, 2018
@manuroe
MXHTTPClient: Send Access-Token as header instead of query param
3f792cf 
element-hq/element-ios#2071

No more need to be paranoid on access token leaks in logged HTTP paths.
@manuroe manuroe mentioned this issue Oct 8, 2018
Merged
@manuroe manuroe closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 parity-with-android parity-with-web T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
Sprint 14
Development

No branches or pull requests
1 participant
@manuroe