Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent black screen when closing window while in full screen mode on macOS #192

Merged
merged 1 commit into from
May 5, 2021
Merged

Prevent black screen when closing window while in full screen mode on macOS #192

merged 1 commit into from
May 5, 2021

Conversation

aaronraimist
Copy link
Contributor

@aaronraimist
Copy link
Contributor Author

aaronraimist commented May 5, 2021 •
edited
Loading

buildkite failures appear to be unrelated to this change. It looks like maybe it is just broken.

./scripts/ci/install-deps.sh: line 5: yarn: command not found

@turt2live turt2live requested a review from a team May 5, 2021 03:04
@jryans
Copy link
Contributor

jryans commented May 5, 2021

buildkite failures appear to be unrelated to this change. It looks like maybe it is just broken.

Correct, matrix-org/pipelines#145 should fix it up once merged.

jryans
jryans approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, thanks! 😄

@jryans jryans merged commit 75b41d6 into element-hq:develop May 5, 2021
@aaronraimist aaronraimist deleted the close-fullscreen-macos branch May 5, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking red X in upper left corner of MacOS Riot app makes app blackscreen
2 participants
@aaronraimist @jryans