Load focus information from well known and use client config only as a fallback. #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
force-pushed
the
toger5/sfu-wellKnown
branch
from
48180b4 to
9c37e74
Compare
AndrewFerr
reviewed
May 27, 2024
AndrewFerr
requested changes
May 28, 2024
AndrewFerr
approved these changes
Jun 4, 2024
toger5
force-pushed
the
toger5/sfu-wellKnown
branch
from
65c7f48 to
d54966f
Compare
…a fallback. Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
rename to org.matrix.matrix_rtc_foci
…vice_url is in the config
make join state independent of isJoined
Co-authored-by: Andrew Ferrazzutti <[email protected]>
Co-authored-by: Andrew Ferrazzutti <[email protected]>
toger5
force-pushed
the
toger5/sfu-wellKnown
branch
from
d54966f to
4992f7b
Compare
Merged
mgcm
pushed a commit
to mgcm/element-call
that referenced
this pull request
Aug 7, 2024
…a fallback. (element-hq#2358) * Load focus information from well known and use client config only as a fallback. Signed-off-by: Timo K <[email protected]> Co-authored-by: Andrew Ferrazzutti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always requireig EC to configure a livekit service url we use the homeserver well-known to aquire the sfu to use.
Relies on: matrix-org/matrix-js-sdk#4195
Discussion:
If the homserver does not promote a service url in the well-known we start searching for one on the other homeservers involved in the room. (check user domains)The reason for this is, that we currently cannot start nor join a call without knowing a sfu service url since we wont just copy over what others have set in their state event.
Even if taht would be possible we could run into a situation where all members with a set foci_active disconnect and only members without foci active are left which would break the call immediately.
So making it a requirement to have a active foci makes sense.
Hence always loading one via the room member list might be a solution
In the current version we have not activated the option to load from other room members.
We add Foci from (in the order listed here)
Signed-off-by: Timo K [email protected]