-
Notifications
You must be signed in to change notification settings - Fork 12
support building on more platforms #58
support building on more platforms #58
Conversation
cc @q66 |
This adds support for building on a lot more linux platforms. Supported architectures now include x86_64, i686, powerpc64le and aarch64. In addition to that, this adds the ability to use musl on each of these as well, in addition to glibc.
7d48521
to
c1e1916
Compare
lgtm, also works for me (tested element 1.8.4, electron 13.x, ppc64le-musl) |
closing & re-opening to try & wake the linter job up... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. If this gets much more complex it's probably going to need something a bit more sophisticated than just this file.
Bit weird that these effectively do nothing & have to be enabled by editing the code. Main issue here is that we have no means of maintaining this as we wouldn't be building for these platforms. Perhaps we could assign a maintainer for some 'community maintained' platforms?
I could be assigned as community maintainer for i686, x86_64 and aarch64, maybe @q66 could do ppc64? |
there is a bunch more stuff needed to get things built on ppc64le, but this part is the only one that's in element itself (the rest is workarounds for electron-builder, so that's a different upstream to address) I test things fairly regularly, so this should be no problem |
@dbkr anything that's needed to move this forward? |
I asked the team about this and the conclusion is that this seems fine. Currently the only 'dead' target in this file is x86 windows (which we previously built but don't anymore) so if we could just add some comments to explain why these targets are sitting around in the file without being enabled, that would be good (and add the semicolons that the linter wants). |
I have plans to resurrect it |
I was under the impression that this bit of code was moved into |
Good point - we should update both if we're changing it, possibly making builder refer to version in element-desktop |
#67 makes the reference happen, please move these changes to element-desktop in their entirety where they'll be accepted with open arms! |
This adds support for building on a lot more linux platforms. Supported
architectures now include x86_64, i686, powerpc64le and
aarch64. In addition to that, this adds the ability to use musl on each
of these as well, in addition to glibc.