Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'sign in' flow more important in the initial screen #8741

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : design change.

Content

  • "I already have an account" and "Create account" buttons in the initial screens have swaped places and styles.
  • "I already have an account" is now "Sign in" to make it clearer to the user.

Motivation and context

Requested by a customer.

Screenshots / GIFs

The new design should look like:

image

Tests

  • Open the app, check the buttons look like the design above.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from bmarty January 30, 2024 11:27
@bmarty
Copy link
Member

bmarty commented Jan 30, 2024

I think this is against all the other apps are doing.
I let @nadonomy give more input on this, the way it is done now was a strong requirement from the design team.

@bmarty bmarty requested a review from nadonomy January 30, 2024 16:06
@jmartinesp
Copy link
Member Author

@bmarty I think Nad already said he was ok with the changes in the associated issue.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jmartinesp jmartinesp merged commit d75ca51 into develop Feb 2, 2024
15 of 16 checks passed
@jmartinesp jmartinesp deleted the fix/jme/update-login-splash-screen branch February 2, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants