Make cryptoDevice calls suspendable #8485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
May 31, 2023
| it.deviceId != session.sessionParams.deviceId | ||
| } | ||
| setState { copy(hasAnyOtherSession = Loading()) } | ||
| viewModelScope.launch(Dispatchers.IO) { |
There was a problem hiding this comment.
I think it's not mandatory to provide a dispatcher here, getCryptoDeviceInfo will switch to this dispatcher using withContext.
| pushersManager.enqueueRegisterPusher(pushKey, gateway) | ||
| runBlocking { | ||
| pushersManager.enqueueRegisterPusher(pushKey, gateway) | ||
| } |
There was a problem hiding this comment.
Instead of using runBlocking, I think we should use runTest, so update the method declaration like this:
fun `when enqueueRegisterPusher, then HttpPusher created and enqueued`() = runTest {| @@ -32,7 +33,7 @@ class DefaultGetDeviceInfoUseCaseTest { | |||
|
|
|||
| @Test | |||
| fun `when execute, then get crypto device info`() { | |||
| val result = getDeviceInfoUseCase.execute() | |||
| val result = runBlocking { getDeviceInfoUseCase.execute() } | |||
There was a problem hiding this comment.
use runTest instead of runBlocking:
fun `when execute, then get crypto device info`() = runTest {
BillCarsonFr
force-pushed
the
feature/bca/fix_anrs
branch
from
3ea8b63 to
7e6376b
Compare
BillCarsonFr
added
the
Z-NextRelease
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Fixes #8482
getCryptoDevicecalls in rust are usingrunBlocking, it was causing ANRs. These calls are now suspendable, updated the code accordingly.Additional change in ReadService on
getHomeServerCapabilities()that was also causing ANRs.Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist