Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for MSC3906 v2 #8212

Closed
wants to merge 4 commits into from
Closed

Support for MSC3906 v2 #8212

wants to merge 4 commits into from

Conversation

hughns
Copy link
Member

@hughns hughns commented Mar 6, 2023 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This PR adds support for v2 of MSC3906 which is used for Sign in with QR.

Both v1 and v2 are supported so compatibility is maintained.

Motivation and context

Screenshots / GIFs

Tests

  • Tested against an Element Web which generates a v1 QR
  • Tested against an Element Web which generates a v2 QR

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Signed-off-by: Hugh Nimmo-Smith [email protected]

@hughns hughns mentioned this pull request Mar 6, 2023
Closed
6 tasks
@hughns hughns force-pushed the hughns/msc3906-v2 branch 3 times, most recently from 8cd3f06 to d83e6ae Compare March 9, 2023 20:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@hughns
Copy link
Member Author

hughns commented Mar 9, 2023

The SonarCloud check is reporting 0% coverage on new code but this is incorrect. It looks like it isn't picking up the test cases from androidTest?

@hughns hughns marked this pull request as ready for review March 9, 2023 22:15
@hughns hughns requested a review from bmarty April 1, 2023 15:58
@hughns hughns requested a review from ElementBot April 11, 2023 15:51
bmarty
bmarty approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@hughns hughns marked this pull request as draft December 11, 2023 10:27
@hughns
Copy link
Member Author

hughns commented Dec 11, 2023

Closing this as not currently a priority to have support for MSC3906 v2 in Android.

@hughns hughns closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@ElementBot ElementBot Awaiting requested review from ElementBot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hughns @bmarty @ElementBot