Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #8202

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Fix CI #8202

merged 2 commits into from
Mar 3, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 3, 2023

Let's see what's happening here.

bmarty added 2 commits March 3, 2023 16:40
@bmarty
sonarqube task is deprecated, use sonar now.
8bb78ce
@bmarty
Fix test by mocking WorkManagerProvider.tag
ceda85f 
Appeared when upgrading androidx.work:work-runtime-ktx from 2.7.1 to 2.8.0 in #8099
@bmarty
Copy link
Member Author

bmarty commented Mar 3, 2023

@mnaturel do you know a better way to fix the issue on test rather than ceda85f (i.e. avoiding making the tag public)?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@bmarty bmarty marked this pull request as ready for review March 3, 2023 17:59
@bmarty bmarty enabled auto-merge March 3, 2023 18:00
yostyle
yostyle approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty merged commit 97b4730 into develop Mar 3, 2023
@bmarty bmarty deleted the feature/bma/fixCi branch March 3, 2023 20:14
@mnaturel
Copy link
Contributor

mnaturel commented Mar 6, 2023

@mnaturel do you know a better way to fix the issue on test rather than ceda85f (i.e. avoiding making the tag public)?

I think there are different possible alternatives:

  • annotate the field with @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
    to warn if we try to use the field externally
  • use the spyk annotation to use a mix between real and mocked object
  • use a relaxed mock to have default behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yostyle yostyle yostyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmarty @mnaturel @yostyle