Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aggregated unread indicator for spaces in the new layout #8159

Merged
merged 14 commits into from
Feb 24, 2023
Merged

Add aggregated unread indicator for spaces in the new layout #8159

merged 14 commits into from
Feb 24, 2023

Conversation

mnaturel
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

In the new app layout, adding a notification badge on top of the floating action button which opens the spaces list bottom sheet.

Motivation and context

Closes #8157

Screenshots / GIFs






Tests

  • Open the app with new layout
  • Send message in some rooms and check the badge counter is correctly displayed
  • Send invite to a space
  • Check the badge counter is red while the space invite is pending

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review February 22, 2023 14:40
@mnaturel mnaturel requested review from a team and jonnyandrew and removed request for a team February 22, 2023 14:41
jonnyandrew
jonnyandrew approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

vector/src/main/java/im/vector/app/features/home/NewHomeDetailFragment.kt Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.1% 81.1% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit a6f7302 into develop Feb 24, 2023
@mnaturel mnaturel deleted the feature/mna/aggregated-unread-indicator branch February 24, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyandrew jonnyandrew jonnyandrew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add aggregated unread indicator for spaces in the new layout
2 participants
@mnaturel @jonnyandrew