Start sync #8019
Merged
Start sync #8019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
added
the
Z-NextRelease
bmarty
requested review from
a team,
ganfra and
Florian14
and removed request for
a team
|
SonarCloud Quality Gate failed. |
ganfra
approved these changes
Jan 30, 2023
Florian14
approved these changes
Jan 30, 2023
| @@ -118,6 +120,8 @@ class HomeActivityViewModel @AssistedInject constructor( | |||
| private fun initialize() { | |||
| if (isInitialized) return | |||
| isInitialized = true | |||
| // Ensure Session is syncing | |||
There was a problem hiding this comment.
Is this comment really useful? Not an issue at all
There was a problem hiding this comment.
Ah, yes, a bit useless. I added the comment when the use case had another name. Could be removed now (but I will not trigger the CI for that).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Ensure sync thread is started when the app recover from a crash or from a process killed by the system.
Motivation and context
See message coming when using the app.
Closes #8010
Also fixing a rendering issue when messages fail to be sent:
/crashcommand, only auto-completed (and active) when in developer mode to crash the app and provokate a recovery.Screenshots / GIFs
Tests
Tested devices
Checklist