[Rich text editor] Add plain text mode and new attachment UI #7459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnyandrew
force-pushed
the
feat/PSU-780-plain-text-rebase-resilience-rc
branch
from
64e1447 to
c5b2d46
Compare
Note these are currently only visible in the collapsed state. - [Google issue](https://issuetracker.google.com/issues/144859239) - [Rejected PR](material-components/material-components-android#437) - [Github issue](material-components/material-components-android#1278)
This reverts commit 17c43c9.
jonnyandrew
force-pushed
the
feat/PSU-780-plain-text-rebase-resilience-rc
branch
from
c5b2d46 to
2b7177b
Compare
jmartinesp
approved these changes
Oct 26, 2022
ElementBot
reviewed
Oct 26, 2022
| @@ -69,14 +63,14 @@ class AttachmentTypeSelectorView( | |||
| init { | |||
| contentView = inflater.inflate(R.layout.view_attachment_type_selector, null, false) | |||
There was a problem hiding this comment.
⚠️ Avoid passingnullas the view root (needed to resolve layout parameters on the inflated layout's root element)⚠️ Avoid passingnullas the view root (needed to resolve layout parameters on the inflated layout's root element)⚠️ Avoid passingnullas the view root (needed to resolve layout parameters on the inflated layout's root element)⚠️ Avoid passingnullas the view root (needed to resolve layout parameters on the inflated layout's root element)
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:background="?colorSurface"> |
There was a problem hiding this comment.
⚠️ Possible overdraw: Root element paints background?colorSurfacewith a theme that also paints a background (inferred theme is@android:style/Theme.Holo)⚠️ Possible overdraw: Root element paints background?colorSurfacewith a theme that also paints a background (inferred theme is@android:style/Theme.Holo)
|
SonarCloud Quality Gate failed. |
jmartinesp
pushed a commit
that referenced
this pull request
Nov 2, 2022
* Add new attachments selection dialog * Add rounded corners to bottom sheet dialog. Note these are currently only visible in the collapsed state. - [Google issue](https://issuetracker.google.com/issues/144859239) - [Rejected PR](material-components/material-components-android#437) - [Github issue](material-components/material-components-android#1278) * Add changelog entry * Remove redundant call to superclass click listener * Refactor to use view visibility helper * Change redundant sealed class to interface * Remove unused string * Revert "Add rounded corners to bottom sheet dialog." This reverts commit 17c43c9. * Remove redundant view group * Remove redundant `this` * Update rich text editor to latest * Update rich text editor version * Allow toggling rich text in the new editor * Persist the text formatting setting * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combination of two changes rebased on
resilience-rc.See the original PRs: