Fix ReleaseNotesActivity displayed after login.

[bmarty]

Ensure the state is up to date, when we will request it later with withState{}

Type of change

• Feature
• Bugfix. Not released so no changelog
• Technical
• Other :

Content

Ensure the state is up to date, else at this point: https://github.com/vector-im/element-android/blob/62e8beadf8c0ece8e56e21b86d9e96c0ec68d3b2/vector/src/main/java/im/vector/app/features/onboarding/ftueauth/FtueAuthVariant.kt#L498 the state is not up to date, and it.selectedAuthenticationState.description is null. So at this point https://github.com/vector-im/element-android/blob/16fad63e49eb408a4ccf066341e5b9cd5745fc66/vector/src/main/java/im/vector/app/features/home/HomeActivityViewModel.kt#L123 state.authenticationDescription is null and we display ReleaseNotesActivity, if never displayed before.

The fix is maybe not the best thing to do, I already had concern about it. But as a quick fix it seems acceptable. I think OnboardingViewState.selectedAuthenticationState should be set earlier.

Tested OK on my side.

Motivation and context

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[ericdecanini]

Should we have an issue to go back to this so we don't forget? (I can write this if you want)

[fedrunov]

LGTM

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication