Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Layout - Allows you to open an invite by clicking its cell #7059

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Sep 7, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Brings back a missing feature that allows you to open an invite by clicking its cell

Motivation and context

Fixes lost functionality

Screenshots / GIFs

Tests

  • Receive an invite (you can do this by DMing your account with a new test account)
  • Open the invites page
  • Click on the cell of the invite outside of the buttons
  • See that you are on the screen as the screenshot above

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 12

Checklist

@ericdecanini
Copy link
Contributor Author

No changelog added as this fixes an unreleased bug

@ericdecanini ericdecanini requested a review from bmarty September 7, 2022 10:00
@ericdecanini ericdecanini marked this pull request as ready for review September 7, 2022 10:04
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
(not tested though, but I assume you played a bit with room invites)

@ericdecanini
Copy link
Contributor Author

LGTM, thanks! (not tested though, but I assume you played a bit with room invites)

Played around I have ✨

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bmarty bmarty merged commit 5dd26a4 into develop Sep 8, 2022
@bmarty bmarty deleted the bugfix/eric/new-layout-open-invite branch September 8, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants