Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voice recording tests #7037

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the test. LGMT, if CI is happy!

@@ -40,7 +41,8 @@ class VoiceRecorderProvider @Inject constructor(
return Build.VERSION.SDK_INT < Build.VERSION_CODES.Q || !hasOpusEncoder() || vectorFeatures.forceUsageOfOpusEncoder()
}

private fun hasOpusEncoder(): Boolean {
@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRIVATE is the default value, but OK to keep it here.

@bmarty
Copy link
Member

bmarty commented Sep 6, 2022

I can confirm that the tests in VoiceRecorderProviderTests are passing on API 28

image

@jmartinesp jmartinesp self-assigned this Sep 6, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jmartinesp jmartinesp marked this pull request as ready for review September 6, 2022 18:08
@jmartinesp jmartinesp merged commit 273999e into develop Sep 6, 2022
@jmartinesp jmartinesp deleted the fix/jorgem/voice-recorder-tests branch September 6, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants