Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest @room when @channel, @everyone, or @here is typed in composer #7000

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

pt2121
Copy link
Contributor

@pt2121 pt2121 commented Sep 4, 2022

Closes #6529

Signed-off-by: Prat T [email protected]

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Addressing #6529 - suggest @room when a user typed in comparable keywords in the compose view.

Motivation and context

following the web client.

Screenshots / GIFs

01
02
03

Tests

  • Log in
  • Navigate to any room that you have a permission to notify the whole room by using @room
  • Type in any @channel, @everyone, or @here
  • See a suggestion for @room

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 12

Checklist

@pt2121 pt2121 marked this pull request as ready for review September 6, 2022 03:45
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Sep 6, 2022
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's looking fine. Enabling the CI.

@bmarty
Copy link
Member

bmarty commented Sep 7, 2022

Fail test is unrelated to the changes here (backupAfterCreateKeysBackupVersionTest). Merging.

@bmarty bmarty merged commit 59e6fa9 into element-hq:develop Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest @room when @channel, @everyone, or @here is typed in composer
2 participants