Remove fragment module

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Remove Fragment module, using Hilt annotation @AndroidEntryPoint instead. Less boilerplate code (and potentially less conflict in the class FragmentModule).

Could be nice to merge fast, since we may have conflict quite fast.

Motivation and context

Fixes #5420 (see details there)

Screenshots / GIFs

NA

Tests

• Running sanity test, OK

- Smoke test on the app using a real device: OK

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[ElementBot]

	Warnings
⚠️	vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt#L1125 - Prefer "SHOW_AS_ACTION_IF_ROOM" instead of "SHOW_AS_ACTION_ALWAYS"
⚠️	vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt#L1125 - Prefer "SHOW_AS_ACTION_IF_ROOM" instead of "SHOW_AS_ACTION_ALWAYS"
⚠️	vector/src/main/java/im/vector/app/features/login/LoginCaptchaFragment.kt#L117 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/login/LoginCaptchaFragment.kt#L117 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/login/LoginCaptchaFragment.kt#L117 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/login/LoginCaptchaFragment.kt#L117 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/login/LoginWebFragment.kt#L135 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/login/LoginWebFragment.kt#L135 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/login/LoginWebFragment.kt#L135 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/login/LoginWebFragment.kt#L135 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/onboarding/ftueauth/FtueAuthWebFragment.kt#L132 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/onboarding/ftueauth/FtueAuthWebFragment.kt#L132 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/onboarding/ftueauth/FtueAuthWebFragment.kt#L132 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/onboarding/ftueauth/FtueAuthWebFragment.kt#L132 - Permitting connections with SSL-related errors could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider canceling the connections by invoking SslErrorHandler#cancel().
⚠️	vector/src/main/java/im/vector/app/features/settings/notifications/VectorSettingsAdvancedNotificationPreferenceFragment.kt#L90 - It will always be more efficient to use more specific change events if you can. Rely on notifyDataSetChanged as a last resort.
⚠️	vector/src/main/java/im/vector/app/features/settings/notifications/VectorSettingsAdvancedNotificationPreferenceFragment.kt#L90 - It will always be more efficient to use more specific change events if you can. Rely on notifyDataSetChanged as a last resort.
⚠️	vector/src/main/java/im/vector/app/features/share/IncomingShareFragment.kt#L83 - Field requires API level 29 (current min is 21): android.content.Intent#EXTRA_SHORTCUT_ID
⚠️	vector/src/main/java/im/vector/app/features/share/IncomingShareFragment.kt#L83 - Field requires API level 29 (current min is 21): android.content.Intent#EXTRA_SHORTCUT_ID

Generated by 🚫 dangerJS against 4c2f853

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

23.5% Coverage
0.0% Duplication

[ganfra]

Didn't tested, but LGTM, thanks for the changes!

[ganfra]

Just what about the Danger warnings?