dialpad moved from bottom navigation tab to a separate activity #6887
Conversation
fedrunov
requested review from
a team,
mnaturel,
ericdecanini,
amshakal and
ouchadam
and removed request for
a team and
mnaturel
| @@ -8,6 +8,11 @@ | |||
| android:title="@string/invite_friends" | |||
| app:showAsAction="never" /> | |||
|
|
|||
| <item | |||
There was a problem hiding this comment.
do we need some logic to determine if the menu item should be visible?
There was a problem hiding this comment.
Yes! Thanks for this catch, I forgot about it
| dismissLoadingDialog() | ||
| finish() | ||
| } catch (failure: Throwable) { | ||
| displayErrorDialog(failure) |
There was a problem hiding this comment.
Will the loading Dialog will be dismiss in this case?
| @@ -107,6 +110,7 @@ class NewHomeDetailFragment @Inject constructor( | |||
| withState(viewModel) { state -> | |||
| val isRoomList = state.currentTab is HomeTab.RoomList | |||
| menu.findItem(R.id.menu_home_mark_all_as_read).isVisible = isRoomList && hasUnreadRooms | |||
| menu.findItem(R.id.menu_home_dialpad).isVisible = state.showDialPadTab | |||
|
|
SonarCloud Quality Gate failed. |
Type of change
Content
since we won't have bottom navigation tabs in new layout, we need to move dialpad somewhere else
Motivation and context
part of #6502
closes #6787
Screenshots / GIFs