FTUE - Crash fixes #6862
FTUE - Crash fixes #6862
Conversation
ouchadam
added
Z-Crash
Z-FTUE
| @@ -260,11 +260,11 @@ class FtueAuthVariant( | |||
| } | |||
|
|
|||
| private fun onStartCombinedLogin() { | |||
| addRegistrationStageFragmentToBackstack(FtueAuthCombinedLoginFragment::class.java) | |||
| addRegistrationStageFragmentToBackstack(FtueAuthCombinedLoginFragment::class.java, allowStateLoss = true) | |||
There was a problem hiding this comment.
allowing state loss for the entry fragments is the fix for #6861
| try { | ||
| inflate() | ||
| } catch (e: Exception) { | ||
| val isMissingWebView = e.crawlCausesFor { it.message?.contains("MissingWebViewPackageException").orFalse() } |
There was a problem hiding this comment.
we have to crawl through the exception causes to find the missing webview package exception, it's a bit hacky~
| } | ||
|
|
||
| private fun inflateWebViewOrShowError() { | ||
| views.loginCaptchaWebViewStub.inflateWebView(onError = { |
There was a problem hiding this comment.
using the ViewStub and handling the inflation error is the fix for #6855
| @@ -492,17 +489,6 @@ class OnboardingViewModel @AssistedInject constructor( | |||
|
|
|||
| private fun handleInitWith(action: OnboardingAction.InitWith) { | |||
| loginConfig = action.loginConfig | |||
| // If there is a pending email validation continue on this step | |||
| try { | |||
There was a problem hiding this comment.
Removing the attempt to fast forward the onboarding state to the wait for email verification stage when the app has been killed and relaunched is the fix for #6860
The OnboardingViewModel and OnboardingViewState already support and are restored by the system restoration process. If the process has been destroyed we need to accumulate the previous view states again otherwise we end up with invalid state.
ouchadam
requested review from
a team and
Florian14
and removed request for
a team
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Could be rewritten to this compact, but maybe less clear:
private fun Throwable.crawlCausesFor(predicate: (Throwable) -> Boolean): Boolean {
return predicate(this) || cause?.crawlCausesFor(predicate) ?: false
}Also, maybe move this extension to a dedicated file for Throwable extensions?
There was a problem hiding this comment.
will extract 👍
as the function is recursive I'd lean towards making the exit conditions as clear as possible, having the recursive call the last line allows us to opt into the tailrec optimisations (although it hasn't been used here since the crash stack is fairly small)
…n occurs asynchronusly
…nsaction occurs asynchronusly
… app is destroyed - this behaviour puts the app in an invalid state as we've lost all the ViewState we've collect from the previous onboarding steps - the app already handles restoring the onboarding state via the system restoration
… the system webview is missing or has been disabled
ouchadam
force-pushed
the
feature/adm/ftue-fragment-crashes
branch
from
0b2b28d to
8b70f3a
Compare
|
|
SonarCloud Quality Gate failed. |
ouchadam
added
the
Z-NextRelease
Type of change
Content
OnboardingViewStateto be in an invalid empty state. Fixes Crash when returning to app after closing during email verification #6860WebViewxml declaration with aViewStubwhich try/catches the inflation. Allows us to catch the missing webview crash and provide an error dialog with information about the error. Fixes App Crashes On Email Verification (Sign Up) #6855already have an accountoruse case selectionbuttons again. Fixes Crash - IllegalStateException: Can not perform this action after onSaveInstanceState #6861Motivation and context
Screenshots / GIFs
WebView disabled
*animations are disabled
Tests
Tested devices