Fixes crash when entering non ascii username during account creation #6736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
ouchadam
requested review from
a team and
ericdecanini
and removed request for
a team
ouchadam
added
the
Z-NextRelease
ouchadam
requested review from
a team and
Claire1817
and removed request for
ericdecanini and
a team
ouchadam
commented
Aug 8, 2022
| ) | ||
| } | ||
| } | ||
| runCatching { registrationWizard.registrationAvailable(userName) }.fold( |
There was a problem hiding this comment.
adding the runCatching is the fix
jmartinesp
requested changes
Aug 9, 2022
jmartinesp
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
It seems like the issue above was fixed in #6741. After rebasing develop and testing again, it's working fine.
|
(We've spoke in the room) The backflow is handled by #6741 this PR is slightly behind develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Motivation and context
Fixes #6735
To avoid a crash when non ascii characters are used in the username during account creation
Screenshots / GIFs
Tests
Tested devices