Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App Layout Toolbar #6655

Merged
merged 9 commits into from
Aug 2, 2022
Merged

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Jul 27, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adds the new app layout toolbar hidden behind the New App Layout Enabled feature flag

Motivation and context

Closes #6580

Figma link: https://www.figma.com/file/Hw4gjP3pknMZUir8jQqmWH/%5BMobile%5D-IA-early-proposals?node-id=2584%3A140337

This does not include behaviour when inside spaces or back navigation

Screenshots / GIFs

Before After After (Collapsed)
Light
Dark
Black

Tests

  • On a fresh install, access the cog at the bottom of the initial screen, go to Features and enable New App Layout
  • Sign in
  • See new app toolbar and ensure profile icon and settings show and react (on click) as expected

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@ericdecanini ericdecanini added the X-Needs-Design May require input from the design team label Jul 27, 2022
@ericdecanini ericdecanini marked this pull request as ready for review July 27, 2022 14:22
Copy link

@amshakal amshakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@ericdecanini ericdecanini removed the X-Needs-Design May require input from the design team label Jul 28, 2022
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
63.6% 63.6% Duplication

@kojid0
Copy link
Contributor

kojid0 commented Jul 28, 2022

grafik

Can't access figma since it not public, but are you sure that the graphics are correct? Why is there a division into DM and Rooms in the "All Chats" view?

@ericdecanini
Copy link
Contributor Author

You'd be right in thinking the diversion should no longer be there. We're tackling the new app layout bit by bit and hiding it behind the aforementioned feature flag until it's complete. Until then, the app as you see it will not have changed in the slightest

@fedrunov fedrunov self-requested a review August 2, 2022 13:19
Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericdecanini ericdecanini merged commit e2ed4b4 into develop Aug 2, 2022
@ericdecanini ericdecanini deleted the feature/eric/app-layout-toolbar branch August 2, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space Switching: Toolbar
4 participants