-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New App Layout Toolbar #6655
New App Layout Toolbar #6655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
SonarCloud Quality Gate failed. |
You'd be right in thinking the diversion should no longer be there. We're tackling the new app layout bit by bit and hiding it behind the aforementioned feature flag until it's complete. Until then, the app as you see it will not have changed in the slightest |
...src/main/java/im/vector/app/features/crypto/keysbackup/setup/KeysBackupSetupStep3Fragment.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change
Content
Adds the new app layout toolbar hidden behind the New App Layout Enabled feature flag
Motivation and context
Closes #6580
Figma link: https://www.figma.com/file/Hw4gjP3pknMZUir8jQqmWH/%5BMobile%5D-IA-early-proposals?node-id=2584%3A140337
This does not include behaviour when inside spaces or back navigation
Screenshots / GIFs
Tests
Tested devices
Checklist