Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTUE - Allow editing email during email verification #6641

Merged
merged 5 commits into from
Jul 27, 2022
Merged

FTUE - Allow editing email during email verification #6641

merged 5 commits into from
Jul 27, 2022

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Jul 26, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Avoids marking the "Waiting for email verification" as a hard exit, which allows the user to go back and edit the entered email address.

  • When restoring the session (eg killing the app whilst within the waiting for verification) the back action will force the user to start the flow again from scratch.

Motivation and context

#6622 Allow editing email during the verification steps

Screenshots / GIFs

BEFORE AFTER
before-change-email after-change-email

Tests

  • With the FTUE flags enabled
  • Start the account creation process on a homeserver with email verification (eg matrix.org)
  • type an incorrect email and press next
  • attempt to go back to edit the email

Tested devices

  • Physical
  • Emulator
  • OS version(s): 28

ouchadam added 5 commits July 26, 2022 11:30
@ouchadam
including knowledge of if the session was restored when fastforwardin…
abab2a0 
…g to the waiting for email
@ouchadam
allowing the child ftue fragments to determine if they're the back ac…
c66b188 
…tion is a hard exit
@ouchadam
allowing the user to edit their email address after starting the verf…
f6070ee 
…ication process

- the email verification screen is no longer a hard exit during the standard account creation flow, however if a authentication session is restored eg the app is killed and reopened whilst waiting for email verifcation, then pressing back will cause the flow to be restarted
@ouchadam
adding changelog entry
796c505
@ouchadam
adding tests around initialising the viewmodel and handling email sen…
fd25503 
…d success actions
@ouchadam ouchadam added the Z-FTUE Issue is relevant to the first time use project or experience label Jul 26, 2022
@ouchadam ouchadam marked this pull request as ready for review July 26, 2022 14:08
@ouchadam ouchadam requested review from a team and yostyle and removed request for a team July 26, 2022 14:08
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

47.1% 47.1% Coverage
0.0% 0.0% Duplication

@ouchadam ouchadam added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jul 26, 2022
yostyle
yostyle approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ouchadam ouchadam merged commit 0fcf7c7 into develop Jul 27, 2022
@ouchadam ouchadam deleted the feature/adm/ftue-soft-exit-email-verification branch July 27, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yostyle yostyle yostyle approved these changes

Assignees
No one assigned
Labels
Z-FTUE Issue is relevant to the first time use project or experience Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouchadam @yostyle