Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix backup looping same keys #6585

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Jul 18, 2022

Type of change

  • Bugfix

Content

Fixes a regression on backup introduced by #5853
The backedUp boolean was reset to false by the InboundGroupSessionStore when saving inbound session.
Also there is no point in persisting back inbound group session after a decryption, so I removed that.

Motivation and context

Tests

Added back the KeysBackupTest, they were ignored.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@BillCarsonFr BillCarsonFr requested a review from bmarty July 18, 2022 15:20
@BillCarsonFr BillCarsonFr force-pushed the feature/bca/fix_backup_regression branch from e946de9 to e30b0ee Compare July 19, 2022 07:22
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Detekt error can be ignored, the issue was on the develop branch.
Let's wait for the test to be fully run before merging this PR.

@BillCarsonFr BillCarsonFr force-pushed the feature/bca/fix_backup_regression branch from e30b0ee to 78afa3f Compare July 20, 2022 07:57
@BillCarsonFr BillCarsonFr enabled auto-merge July 20, 2022 07:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@BillCarsonFr BillCarsonFr merged commit a8cd77c into develop Jul 20, 2022
@BillCarsonFr BillCarsonFr deleted the feature/bca/fix_backup_regression branch July 20, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants