Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong voice message being displayed and played on the timeline. #6556

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fixes #6213 .

Motivation and context

Sometimes, voice message events can get their audio contents replace with some incorrect ones in the timeline. It looks like it was caused by the waveform and playback logic being set up in the ViewHolder incorrectly. To fix it, I used the alternative mentioned here.

Tests

  • From the Android app, send a voice message in a conversation.
  • From another session, reply with another voice message.
  • The received voice message should display its own waveform and play the right audio.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 12

Checklist

@jmartinesp jmartinesp requested a review from a team July 14, 2022 11:32
@jmartinesp jmartinesp self-assigned this Jul 14, 2022
@jmartinesp jmartinesp requested review from ouchadam and removed request for a team July 14, 2022 11:32
Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! fixed the issue for me locally 💯

@jmartinesp jmartinesp force-pushed the fix/jorgem/wrong-voice-message-will-playback branch from b538d34 to 91c2921 Compare July 14, 2022 13:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jmartinesp jmartinesp merged commit 6c1016c into develop Jul 14, 2022
@jmartinesp jmartinesp deleted the fix/jorgem/wrong-voice-message-will-playback branch July 14, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Voice Messages will playback in Timeline
2 participants