FTUE - Combined register copy review

[ouchadam]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

• Matches iOS and checks for user name availability on the loss of focus on the user name field
• Updates the register page design to match the latest iteration of the designs (removes the subtitle and selected homeserver description)
• Adds a footer to the user name reinforcing the full matrix id as a way of discoverability
• Adds a check for minimum 8 characters password length

Motivation and context

Fixes #6546

To simplify the registration screen copy and reinforce the matrix id concept

Screenshots / GIFs

BEFORE	AFTER

PASSWORD MINIMUM	USERNAME TAKEN	FULL MATRIX ID

Tests

• With the combined register feature flag enabled and start the registration process

• Attempt to register with an account that already exists

• Attempt to register with a password shorter than 8 characters

Tested devices

• Physical
• Emulator
• OS version(s):

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

53.8% Coverage
0.0% Duplication

[bmarty]

My 2 cents: some homeservers may have other rules for password (length, char type usage, etc.). We may have a first error with "password must be 8 chars minimum", then later "password must be 10 chars minimum", which is quite annoying. I would avoid clients to do local check on this field and let the config server side.

[Florian14]

Not sure that the lint will be ok but I suggest to name the string parameter inside the lambda for clarity

Suggested change

	private fun maybeUpdateHomeserver(userNameOrMatrixId: String, continuation: suspend (String) -> Unit = {}) {
	private fun maybeUpdateHomeserver(userNameOrMatrixId: String, continuation: suspend (userName: String) -> Unit = {}) {

[bmarty]

I agree with this remark, also having an optional lambda for continuation is a bit strange to me.
Adam may iterate later, we need to merge the PR and review the next one before tomorrow, and this is not a blocker.