Feature/fga/experiment await room #6543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
ouchadam
reviewed
Aug 22, 2022
| timelineFactory: TimelineFactory, | ||
| appStateHandler: AppStateHandler, | ||
| ) : VectorViewModel<RoomDetailViewState, RoomDetailAction, RoomDetailViewEvents>(initialState), | ||
| Timeline.Listener, ChatEffectManager.Delegate, CallProtocolsChecker.Listener, LocationSharingServiceConnection.Callback { | ||
|
|
||
| private val room = session.getRoom(initialState.roomId)!! | ||
| private val room = viewModelScope.async(start = CoroutineStart.LAZY) { | ||
| session.roomService().awaitRoom(initialState.roomId)!! |
There was a problem hiding this comment.
not for this PR, with this async I'm hoping it'll be easier to gracefully handle when the room is null 🤞
#5611
ouchadam
reviewed
Aug 22, 2022
| viewModelScope.launch { | ||
| timeline.await().also { | ||
| it.start(initialState.rootThreadEventId) | ||
| it.addListener(this@TimelineViewModel) |
There was a problem hiding this comment.
is it possible for start to trigger the listener before it's finished being added?
15 tasks
|
A PR will have to be re-open if we want this change to land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment for using suspending function over the db queries.
Offer
awaitRoomandawaitRoomSummarymethods just wrappinggetRoomandgetRoomSummarywithwithContext.Might be interesting to try realm-kotlin before moving to #5842.