[Location Share] - Standardise "Stop" texts for live (PSG-622) #6542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaturel
requested review from
a team and
onurays
and removed request for
a team
onurays
reviewed
Jul 14, 2022
| <item name="android:gravity">center</item> | ||
| <item name="android:padding">0dp</item> | ||
| <item name="android:minWidth">0dp</item> |
There was a problem hiding this comment.
Is this necessary while we already set width of the view?
There was a problem hiding this comment.
Yes this is the tricky part. We want the buttons to respect certain insets on the sides. If we don't have the minWidth property, it does not take the insets into account...
onurays
reviewed
Jul 14, 2022
| <item name="android:gravity">center</item> | ||
| <item name="android:padding">0dp</item> | ||
| <item name="android:minWidth">0dp</item> |
onurays
reviewed
Jul 14, 2022
| <item name="android:gravity">center</item> | ||
| <item name="android:padding">0dp</item> | ||
| <item name="android:minWidth">0dp</item> |
onurays
approved these changes
Jul 14, 2022
mnaturel
force-pushed
the
feature/mna/lls-standardise-stop-text
branch
from
feb66c1 to
cedeb8f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Using the same text for stop button in live location share feature.
Fixing some button insets problem on some languages.
Motivation and context
Closes #6541
Screenshots / GIFs
Tests
Tested devices
Checklist