Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConcurrentModificationException on BackgroundDetectionObserver #6469

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Fix ConcurrentModificationException on BackgroundDetectionObserver #6469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b847d8c
Fix ConcurrentModificationException on BackgroundDetectionObserver
bmarty Jul 5, 2022
b68e01c
Changelog
bmarty Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/6469.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix ConcurrentModificationException on BackgroundDetectionObserver
3 changes: 2 additions & 1 deletion ...android/src/main/java/org/matrix/android/sdk/internal/util/BackgroundDetectionObserver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package org.matrix.android.sdk.internal.util
import androidx.lifecycle.DefaultLifecycleObserver
import androidx.lifecycle.LifecycleOwner
import timber.log.Timber
import java.util.concurrent.CopyOnWriteArraySet

internal interface BackgroundDetectionObserver : DefaultLifecycleObserver {
val isInBackground: Boolean
Expand All @@ -37,7 +38,7 @@ internal class DefaultBackgroundDetectionObserver : BackgroundDetectionObserver
override var isInBackground: Boolean = true
private set

private val listeners = LinkedHashSet<BackgroundDetectionObserver.Listener>()
private val listeners = CopyOnWriteArraySet<BackgroundDetectionObserver.Listener>()

override fun register(listener: BackgroundDetectionObserver.Listener) {
listeners.add(listener)
Expand Down