-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Location sharing] Fix crash when starting/stopping a live when offline (PSF-1124) #6316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaturel
force-pushed
the
fix/mna/crash-offline-lls
branch
from
June 16, 2022 08:39
c7d1301
to
901544b
Compare
mnaturel
requested review from
a team,
onurays and
ganfra
and removed request for
a team
June 16, 2022 09:28
ganfra
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mnaturel
force-pushed
the
feature/mna/location-sharing-service-api
branch
from
June 20, 2022 07:38
f1ca56e
to
dcca546
Compare
onurays
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements! LGTM.
mnaturel
force-pushed
the
fix/mna/crash-offline-lls
branch
from
June 20, 2022 09:28
901544b
to
9047d9d
Compare
SonarCloud Quality Gate failed. |
mnaturel
force-pushed
the
feature/mna/location-sharing-service-api
branch
from
June 20, 2022 11:06
b16ccf5
to
7ddec67
Compare
Base automatically changed from
feature/mna/location-sharing-service-api
to
develop
June 20, 2022 11:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Catching errors which may be thrown during start/stop process of a live location share. The errors are forwarded to the UI: an error dialog is shown in both
TimelineFragment
andLocationLiveMapViewFragment
.Motivation and context
Closes #6315
Fixes https://github.com/matrix-org/element-android-rageshakes/issues/39071
Screenshots / GIFs
Tests
Tested devices
Checklist