Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Location sharing] Fix crash when starting/stopping a live when offline (PSF-1124) #6316

Merged
merged 11 commits into from
Jun 20, 2022

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Jun 15, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Catching errors which may be thrown during start/stop process of a live location share. The errors are forwarded to the UI: an error dialog is shown in both TimelineFragment and LocationLiveMapViewFragment.

Motivation and context

Closes #6315
Fixes https://github.com/matrix-org/element-android-rageshakes/issues/39071

Screenshots / GIFs

Tests

  • Enable airplane mode
  • Start a live location share
  • Check an error dialog is shown in the timeline screen
  • Disable airplane mode
  • Start a live location share
  • Check the live is correctly started
  • Enable airplane mode
  • Stop the live
  • Check an error dialog is shown in the timeline screen
  • Go to the map screen
  • Stop the live
  • Check an error dialog is shown in the map screen
  • Disable airplane mode
  • Stop the live
  • Check the live is correctly stopped

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel force-pushed the fix/mna/crash-offline-lls branch from c7d1301 to 901544b Compare June 16, 2022 08:39
@mnaturel mnaturel requested review from a team, onurays and ganfra and removed request for a team June 16, 2022 09:28
@mnaturel mnaturel marked this pull request as ready for review June 16, 2022 13:35
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mnaturel mnaturel force-pushed the feature/mna/location-sharing-service-api branch from f1ca56e to dcca546 Compare June 20, 2022 07:38
Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! LGTM.

@mnaturel mnaturel force-pushed the fix/mna/crash-offline-lls branch from 901544b to 9047d9d Compare June 20, 2022 09:28
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel force-pushed the feature/mna/location-sharing-service-api branch from b16ccf5 to 7ddec67 Compare June 20, 2022 11:06
Base automatically changed from feature/mna/location-sharing-service-api to develop June 20, 2022 11:48
@mnaturel mnaturel merged commit 32c6281 into develop Jun 20, 2022
@mnaturel mnaturel deleted the fix/mna/crash-offline-lls branch June 20, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Location sharing] - Crash when starting/stopping a live when offline
3 participants