Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade gradle from 7.2.0 to 7.1.3 #6141

Merged
merged 3 commits into from
May 24, 2022

Conversation

michaelkaye
Copy link
Contributor

@michaelkaye michaelkaye commented May 24, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

We downgrade the gradle version to address issues with running jacoco unit test coverage and the realm plugin together.

Motivation and context

Based on tests; if the realm plugin is enabled then jacoco will not instrument classes, leading to no coverage information for those tests. This affects things in the android instrumented tests.

If we disable realm then the coverage succeeds.

If we downgrade the gradle version then coverage succeeds regardless of the realm status.

This is a big enough actual change that downgrading separately to work on the coverage tests is valid.

Checklist

@michaelkaye michaelkaye requested review from a team, ouchadam and mnaturel and removed request for a team May 24, 2022 15:40
@michaelkaye
Copy link
Contributor Author

Fixes #6142

@michaelkaye michaelkaye enabled auto-merge May 24, 2022 16:46
@github-actions
Copy link

Unit Test Results

124 files  ±0  124 suites  ±0   2m 8s ⏱️ +5s
220 tests ±0  220 ✔️ ±0  0 💤 ±0  0 ±0 
726 runs  ±0  726 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 5faa2ff. ± Comparison against base commit b4b2b97.

@michaelkaye michaelkaye merged commit e1dde0c into develop May 24, 2022
@michaelkaye michaelkaye deleted the michaelk/downgrade_gradle_dependency branch May 24, 2022 17:02
@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    = passed=20 failures=0 errors=0 skipped=3
  • [org.matrix.android.sdk.account]
    = passed=3 failures=0 errors=0 skipped=2
  • [org.matrix.android.sdk.internal]
    = passed=28 failures=0 errors=0 skipped=0
  • [org.matrix.android.sdk.ordering]
    = passed=16 failures=0 errors=0 skipped=0
  • [org.matrix.android.sdk.PermalinkParserTest]
    = passed=2 failures=0 errors=0 skipped=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants