FTUE - Msisdn (phone number) entry #6108
Conversation
ouchadam
force-pushed
the
feature/adm/ftue-register-test-cases
branch
from
0a13e9a to
171056e
Compare
ouchadam
force-pushed
the
feature/adm/ftue-register-test-cases
branch
from
171056e to
680b9a0
Compare
ouchadam
force-pushed
the
feature/adm/ftue-register-test-cases
branch
2 times, most recently
from
6d281ff to
befcfe8
Compare
ouchadam
force-pushed
the
feature/adm/ftue-msisdn-entry
branch
2 times, most recently
from
6fccd1c to
666bf0e
Compare
ouchadam
force-pushed
the
feature/adm/ftue-msisdn-entry
branch
from
ec6beae to
ddbb64d
Compare
ouchadam
added
the
Z-FTUE
ouchadam
requested review from
a team,
Florian14 and
ericdecanini
and removed request for
a team
|
Not reviewed yet but if it's a draft because it depends on another PR, wouldn't it be better to set this one's destination to the branch of that pr and add a do not merge tag so this can be reviewed in isolation? |
|
@ericdecanini my bad, I had forgot to update the PR description, I promoted this from a draft because the dependent branch has been merged 😄 |
| data class Success(val countryCode: String, val phoneNumber: String) : Result | ||
| } | ||
|
|
||
| private fun String.doesNotStartWith(input: String) = !startsWith(input) |
ouchadam
force-pushed
the
feature/adm/ftue-msisdn-entry
branch
from
ddbb64d to
5857387
Compare
|
|
||
| fun parseInternationalNumber(rawPhoneNumber: String): Result { | ||
| return when { | ||
| rawPhoneNumber.doesNotStartWith("+") -> Result.ErrorMissingInternationalCode |
There was a problem hiding this comment.
International phone numbers can also start with "00" instead of "+". Perhaps we should check that too?
There was a problem hiding this comment.
TIL
To avoid confusion especially in international context, a plus sign (+) is often used as a graphic symbol of the international access code; it informs the caller to replace it with the prefix code appropriate for their country.[3] Additionally, the GSM mobile telephony standard allows the use of the plus sign in place of the international call prefix; the mobile operator then automatically converts the plus sign to the correct international prefix, depending on the location where the phone is being used. This enables callers to use the same stored number when calling from any country.
https://en.wikipedia.org/wiki/International_call_prefix
tl;dr mobile networks automatically covert from + to the correct IDD prefix
we would have to support multiple variants of 00, 011 etc which wouldn't scale too well and for the most part should be safe to replace with a +
There was a problem hiding this comment.
Yeah...... let's stick with the + 😂
ouchadam
force-pushed
the
feature/adm/ftue-msisdn-entry
branch
from
5857387 to
bfa50f1
Compare
|
SonarCloud Quality Gate failed. |
Type of change
Content
Partly addresses #6043 - the confirmation screen is currently being designed and will be raised in a separate PR
Adds an updated styling version of the Phone number (Msisdn) entry
Motivation and context
To update the phone number entry flow
Screenshots / GIFs
Tests
Tested devices