Run the PR test after merge and report to channel if it fails #5962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkaye
requested review from
a team,
yostyle and
mnaturel
and removed request for
a team
mnaturel
reviewed
May 9, 2022
.github/workflows/sonarqube.yml
Outdated
| needs: | ||
| - sonarqube | ||
| - codecov-units | ||
| if: always() && needs.sonarqube.result != "success" and needs.codecov-units.result != "success" |
There was a problem hiding this comment.
For this condition, I would have expect something like:
if: always() && (needs.sonarqube.result != "success" || needs.codecov-units.result != "success")
I guess we should notify in case either the sonarqube job or the code coverage job fails. And also I am not sure we can use and instead of &&? What do you think?
There was a problem hiding this comment.
Argh, yes; I made this fix in post-pr.yml but not here - good catch.
mnaturel
reviewed
May 9, 2022
mnaturel
approved these changes
May 9, 2022
michaelkaye
force-pushed
the
michaelk/run_pr_test_after_merge
branch
from
4ea18d4 to
5cc0b86
Compare
ouchadam
pushed a commit
that referenced
this pull request
May 12, 2022
* Fork sonarqube run into a nightly build, report failures back to channel. * Each PR triggers a build after merge, report failures back to channel.
piersonleo
pushed a commit
to piersonleo/element-android
that referenced
this pull request
Jun 7, 2022
…t-hq#5962) * Fork sonarqube run into a nightly build, report failures back to channel. * Each PR triggers a build after merge, report failures back to channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally move sonarqube as the only nightly run; and again report to the channel only if it fails.
This should reduce noise in the channel and also provide feedback on who merged a PR with a failing test in it.