-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdk user story #5952
Merged
+667
−241
Merged
Sdk user story #5952
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bad62be
Use Kdoc format, else it's not extracted to the documentation by dokka
bmarty 96c825e
Create _userstories package and add the 2 first user stories
bmarty cfd6456
Add other user stories (with TODO)
bmarty e6c8ffd
Change `val` to `fun` on the SDK interfaces.
bmarty 768df33
Rename `currentThreePid` to `getCurrentThreePid`
bmarty d3d17eb
Extract HttpPusher to its own file
bmarty 1ab4ae9
Extract KeyRef to its own file
bmarty ede7846
Change in KeysBackupService: `isEnabled` and `isStucked` are now fun,…
bmarty 853c0a2
Method `onSecretKeyGossip` doe snot have to be in the public interface
bmarty 740acda
Please ktlint. Ok, the user story will appear at the end of the doc.
bmarty 6e3979a
Fix test compilation
bmarty d92875e
Improve documentation
bmarty dc1eba2
Improve documentation
bmarty 268c41a
Changelog
bmarty 8d74acf
Fix post rebase issue
bmarty 8218d8f
Typo: isStucked -> isStuck
bmarty 827c7e5
Package have been renamed, so also rename it here.
bmarty b866935
`class` with `private constructor` instead of `object`
bmarty 0307e57
Add note about API renaming
bmarty 92d54dc
Fix compilation issue
bmarty 53c83ab
Add missing punctuation
bmarty 8f06415
Fix compilation issue after rebase
bmarty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change in KeysBackupService:
isEnabled
and isStucked
are now fun,…
… and `state` has been renamed to `getState` and is now a fun.
- v1.6.26
- v1.6.24
- v1.6.22
- v1.6.20
- v1.6.18
- v1.6.16
- v1.6.14
- v1.6.12
- v1.6.10
- v1.6.8
- v1.6.6
- v1.6.5
- v1.6.3
- v1.6.2
- v1.6.1
- v1.6.0
- v1.5.32
- v1.5.30
- v1.5.28
- v1.5.26
- v1.5.25
- v1.5.24
- v1.5.22
- v1.5.20
- v1.5.18
- v1.5.16
- v1.5.14
- v1.5.13
- v1.5.12
- v1.5.11
- v1.5.10
- v1.5.8
- v1.5.7
- v1.5.6
- v1.5.4
- v1.5.2
- v1.5.1
- v1.5.0
- v1.4.36
- v1.4.34
- v1.4.32
- v1.4.31
- v1.4.30
- v1.4.28
- v1.4.27
- v1.4.27-RC2
- v1.4.26
- v1.4.25
- v1.4.24
- v1.4.22
- v1.4.20
- v1.4.19
- v1.4.18
commit ede784684f6be4ee8b2327c7b64667375b8e0046
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it should be
isStuck()
instead. The version with "ed" seems to not exist.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When renaming a method which is exposed as an API, should we add an entry in the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, will add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eb57680