Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aris/threads improve rendering issue 5151 #5927

Merged

Conversation

ariskotsomitopoulos
Copy link
Contributor

Closes issue #5151

This PR improves the threads rendering in the main timeline.

Before After
5151_before 5151_after

@github-actions
Copy link

github-actions bot commented May 4, 2022

Unit Test Results

122 files  122 suites   2m 6s ⏱️
205 tests 205 ✔️ 0 💤 0
690 runs  690 ✔️ 0 💤 0

Results for commit 5c645c1.

@ariskotsomitopoulos ariskotsomitopoulos requested review from a team, MadLittleMods, ouchadam and ganfra and removed request for a team and MadLittleMods May 6, 2022 07:58
@ouchadam
Copy link
Contributor

ouchadam commented May 6, 2022

took me a while to notice the difference 😅 looks good! 👍

@@ -0,0 +1 @@
Improve threads rendering in the main timeline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we mention what the improvement was in the changelog? (stopping threads from breaking message chains)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the changelog can be a bit more precise

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ariskotsomitopoulos ariskotsomitopoulos merged commit 3c9b5d2 into develop May 6, 2022
@ariskotsomitopoulos ariskotsomitopoulos deleted the feature/aris/threads_improve_rendering_issue_5151 branch May 6, 2022 14:19
@MadLittleMods MadLittleMods added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Threads An issue for the Threads project labels May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads An issue for the Threads project T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants