Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash - Konfetti API 21/22 crash #5926

Merged
merged 1 commit into from
May 4, 2022
Merged

Crash - Konfetti API 21/22 crash #5926

merged 1 commit into from
May 4, 2022

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented May 4, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fixes #5925

The Konfetti v2 upgrade introduce a regression which meant android api 21/22 were no longer able to view the timeline

  • The fix is to catch the exception caused by the unexpected non initialised fields in our own CompatKonfettiView

Motivation and context

To fix a crash!

Screenshots / GIFs

Before After
before-konfetti-crash after-konfetti-crash

Tests

  • Using a device running android 21
  • open the timeline
  • notice the crash

Tested devices

  • Physical
  • Emulator
  • OS version(s): 21

@ouchadam ouchadam added Z-Crash Z-NextRelease For issues and PRs which should be included in the NextRelease. labels May 4, 2022
@ouchadam ouchadam requested review from a team, bmarty and ericdecanini and removed request for a team May 4, 2022 09:26
@ouchadam ouchadam force-pushed the bugfix/adm/konfetti-crash branch from 456c503 to 9fd56f0 Compare May 4, 2022 09:31
bmarty
bmarty approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions
Copy link

github-actions bot commented May 4, 2022

Unit Test Results

122 files  ±0  122 suites  ±0   2m 2s ⏱️ -7s
205 tests ±0  205 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
690 runs  ±0  690 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9fd56f0. ± Comparison against base commit b5a0c94.

ganfra
ganfra approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ouchadam ouchadam merged commit 76a285e into develop May 4, 2022
@ouchadam ouchadam deleted the bugfix/adm/konfetti-crash branch May 4, 2022 10:16
@bmarty bmarty mentioned this pull request May 4, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra approved these changes

@bmarty bmarty bmarty approved these changes

@ericdecanini ericdecanini Awaiting requested review from ericdecanini ericdecanini was automatically assigned from element-hq/element-android-reviewers

Assignees
No one assigned
Labels
Z-Crash Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash - Konfetti NullPointerException
3 participants
@ouchadam @bmarty @ganfra