Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Add missing return type in RoomApi.sendStateEvent() #5912

Merged
merged 3 commits into from
May 4, 2022

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented May 3, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : Enhancement

Content

Returning the id of the newly created state event in methods to send state events.

Motivation and context

Closes #5855
For instance, In some situation it may be useful to know the id of the newly created event to attach other related events to it.

Screenshots / GIFs

Tests

  • Change the name of a room
  • Check you see log of the creation of the state event.

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel requested review from a team, Claire1817 and ariskotsomitopoulos and removed request for a team May 3, 2022 13:21
@mnaturel mnaturel added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements matrix-sdk labels May 3, 2022
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented May 3, 2022

Unit Test Results

122 files  122 suites   2m 2s ⏱️
205 tests 205 ✔️ 0 💤 0
690 runs  690 ✔️ 0 💤 0

Results for commit 3b022ee.

@mnaturel mnaturel merged commit 63119ca into develop May 4, 2022
@mnaturel mnaturel deleted the fix/mna/issue-5855-response-state-event branch May 4, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
matrix-sdk T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] Missing return type in RoomApi.sendStateEvent()
3 participants