#5667: [Location Sharing] - Set duration of live sharing

[mnaturel]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Adding a new bottom sheet to ask user to choose between different maximum duration for the share. It is displayed before starting the live location sharing.

Motivation and context

Closes #5667

Screenshots / GIFs

Tests

• Ensure location sharing is enabled in "Settings -> Preferences"
• Go to a room
• Select location sharing by pressing the add button and then the locate icon
• Press live location sharing option
• Check a dismissable bottom sheet is displayed with the different duration options
• Select one of the durations
• Press the share button
• Check the location sharing screen is closed
• Check the live location service is started

Tested devices

• Physical
• Emulator
• OS version(s): Android 11

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[gaelledel]

Slight styling updates for Light and Dark themes on the bottom action sheet are needed see specs here https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=1240%3A92359
The Action button at the bottom should be larger in height see specs 48px

[github-actions]

Unit Test Results

110 files  ±0  110 suites  ±0   1m 12s ⏱️ -1s
195 tests ±0  195 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
650 runs  ±0  650 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit de59f9f. ± Comparison against base commit d05d697.

♻️ This comment has been updated with latest results.

[mnaturel]

Slight styling updates for Light and Dark themes on the bottom action sheet are needed see specs here https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=1240%3A92359 The Action button at the bottom should be larger in height see specs 48px

I increased the height of the "Share" button (see new captures below). Is it okay?

[gaelledel]

Yes the button height is now OK - still need to change the style of the sheet themselves i.e: Dark mode seems to be using the wrong bg colour. We also only have separator under the title Action

[mnaturel]

Yes the button height is now OK - still need to change the style of the sheet themselves i.e: Dark mode seems to be using the wrong bg colour. We also only have separator under the title Action

Sorry, I totally missed the background color. Below are the new captures after adjustments. However, I am not sure the specs are correct for the light version of the design. We are using the element_system colors for background of bottom sheets and the quinary_content color for the dividers. It matches the design of the dark version but not the one of the light version, was it intented?

[gaelledel]

Great thanks!

[fedrunov]

Looks good