Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes voice call button disappearing in DM rooms with more than 2 members #5548

Merged
merged 6 commits into from
Mar 29, 2022
Merged

Fixes voice call button disappearing in DM rooms with more than 2 members #5548

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
38f3b88
Adds debug test to check roomSummary for voice call button
ericdecanini Mar 15, 2022
d74d569
Adds back default to true on isWebRTCCallOptionAvailable
ericdecanini Mar 15, 2022
82ead4f
Replaces call option condition with isDirect
ericdecanini Mar 15, 2022
5d496d5
Adds changelog file
ericdecanini Mar 15, 2022
f722b2e
Removes unused import
ericdecanini Mar 15, 2022
bfd31de
Renames call option to be more agnostic
ericdecanini Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5548.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixes voice call button disappearing in DM rooms with more than 2 members
2 changes: 1 addition & 1 deletion vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailViewState.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ data class RoomDetailViewState(
rootThreadEventId = args.threadTimelineArgs?.rootThreadEventId
)

fun isWebRTCCallOptionAvailable() = (asyncRoomSummary.invoke()?.joinedMembersCount ?: 0) <= 2
fun isWebRTCCallOptionAvailable() = asyncRoomSummary.invoke()?.isDirect ?: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough context about our support for more than 2 people. Web client is creating a Jitsi video call widget even if you click to voice call button. @ganfra what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes WebRtc is only working with one opponent, otherwise it should be a jitsi call (with video disabled then)

Copy link
Contributor Author

@ericdecanini ericdecanini Mar 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this must be why it was disabled previously. Thanks for the context, I'll reapproach this!

Edit: Upon looking at the code, the call should still be working as a Jitsi audio call out-the-box. I renamed the above function to be more agnostic towards the type of call


fun isSearchAvailable() = asyncRoomSummary()?.isEncrypted == false

Expand Down