Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Spaces menu ordering and capitalisation #5539

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Update Spaces menu ordering and capitalisation #5539

merged 1 commit into from
Apr 5, 2022

Conversation

fedrunov
Copy link
Contributor

@fedrunov fedrunov commented Mar 15, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : misc

Content

Update Spaces menu ordering and capitalisation

Motivation and context

fixes #5524

Screenshots / GIFs

image

Tests

  • open left slider menu
  • open space menu

Tested devices

  • Physical
  • Emulator
  • OS version(s): 31

Checklist

@github-actions
Copy link

Unit Test Results

  98 files  ±0    98 suites  ±0   1m 11s ⏱️ +6s
178 tests ±0  178 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
584 runs  ±0  584 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2044839. ± Comparison against base commit 5de7873.

@fedrunov
Copy link
Contributor Author

We probably also need to change capitalisation in other locales, what is the best way to do so? Just update manually in string resources and commit to this PR or somehow else?

@kittykat kittykat mentioned this pull request Mar 22, 2022
Closed
@fedrunov fedrunov requested review from a team and ouchadam and removed request for a team March 31, 2022 07:05
@fedrunov fedrunov mentioned this pull request Mar 31, 2022
Merged
15 tasks
ouchadam
ouchadam approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm assuming the space sanity tests are already using the strings so we don't need to update them?

ouchadam
ouchadam reviewed Mar 31, 2022
View reviewed changes
vector/src/main/res/layout/bottom_sheet_space_settings.xml
app:tint="?vctr_content_secondary"
app:titleTextColor="?vctr_content_primary"
tools:actionDescription="" />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like an extra bonus line was added

@fedrunov
Copy link
Contributor Author

I'm assuming the space sanity tests are already using the strings so we don't need to update them?

What do you mean? 🤔

@ouchadam
Copy link
Contributor

I'm assuming the space sanity tests are already using the strings so we don't need to update them?

What do you mean? thinking

with order/value change, do we need to update https://github.com/vector-im/element-android/blob/develop/vector/src/androidTest/java/im/vector/app/ui/UiAllScreensSanityTest.kt#L112 ? 🤔

@fedrunov
Copy link
Contributor Author

with order/value change, do we need to update https://github.com/vector-im/element-android/blob/develop/vector/src/androidTest/java/im/vector/app/ui/UiAllScreensSanityTest.kt#L112 ? 🤔

got it, no, tests are relying on widget ids, so nothing will change there

@fedrunov fedrunov merged commit 0664afd into develop Apr 5, 2022
@fedrunov fedrunov deleted the feature/nfe/reorder_spaces_menu branch April 5, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ouchadam ouchadam ouchadam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Spaces menu ordering and capitalisation
2 participants
@fedrunov @ouchadam