Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTUE - Finalising personalisation journey #5519

Merged
merged 8 commits into from
Mar 30, 2022
Merged

FTUE - Finalising personalisation journey #5519

merged 8 commits into from
Mar 30, 2022

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Mar 11, 2022 •
edited
Loading

Marked as draft as this relies on #5517

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Part of #5200 (will be fully closed once the feature is enabled)

  • Adds the personalisation steps to the UI Sanity tests
  • Promotes the WIP strings to the main file, ready for translators to pick up

Motivation and context

To promote and enable users to customise their account as soon as they sign up

Screenshots / GIFs

Pixel 4 XL

1 2 3 4
after-tall-1 after-tall-2 after-tall-3 after-tall-4
after-1-l after-2-l after-3-l after-l-4

Tiny device

1 2 3 4
after-1-s after-2-s after-3-s aftrer-4-s

Nexus 9

1 2 3 4
after-1-t after-2-t after-3-t after-4-t
after-1-p after-2-p after-3-p after-4-p
PERSONALISATION ENABLED PERSONALISATION DISABLED ONLY DISPLAY NAME ONLY PROFILE PICTURE
after-gif after-disabled after-only-dn after-only-pp

Tests

  • Create a new account!

Tested devices

  • Physical
  • Emulator
  • OS version(s): 28, 29, 32 (Sv1)

@ouchadam ouchadam added X-Needs-Design May require input from the design team Z-FTUE Issue is relevant to the first time use project or experience X-Needs-Product Issue needs input from Product team labels Mar 11, 2022
@github-actions
Copy link

github-actions bot commented Mar 11, 2022 •
edited
Loading

Unit Test Results

110 files  ±0  110 suites  ±0   1m 27s ⏱️ -9s
195 tests ±0  195 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
650 runs  ±0  650 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0ffd20e. ± Comparison against base commit 9c333c9.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. 
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given registration has started and has dummy step to do, when handling action, then ignores other steps and executes dummy
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ when registering account, then updates state and emits account created event

im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given personalisation enabled and registration has started and has dummy step to do, when handling action, then ignores other steps and executes dummy
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given personalisation enabled, when registering account, then updates state and emits account created event

♻️ This comment has been updated with latest results.

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Mar 11, 2022 •
edited
Loading

Watched the demo, it looks great. ✅

@daniellekirkwood daniellekirkwood removed the X-Needs-Product Issue needs input from Product team label Mar 11, 2022
@ouchadam ouchadam mentioned this pull request Mar 11, 2022
Closed
10 tasks
@ouchadam ouchadam requested a review from amshakal March 15, 2022 14:53
@amshakal
Copy link

amshakal commented Mar 15, 2022 •
edited
Loading

Looks great! Specially the implementation on small screen 👯‍♀️

@ouchadam ouchadam mentioned this pull request Mar 17, 2022
Merged
6 tasks
@ouchadam ouchadam force-pushed the feature/adm/ftue-single-loading-state branch from 63c7e2b to bbc892f Compare March 18, 2022 16:35
@ouchadam ouchadam removed the X-Needs-Design May require input from the design team label Mar 22, 2022
@ouchadam ouchadam mentioned this pull request Mar 23, 2022
Merged
6 tasks
@ouchadam ouchadam force-pushed the feature/adm/ftue-single-loading-state branch from bbc892f to af90ada Compare March 23, 2022 17:29
Base automatically changed from feature/adm/ftue-single-loading-state to develop March 24, 2022 10:36
@ouchadam ouchadam force-pushed the feature/adm/enabling-personalisation branch from 1da7215 to 552fd97 Compare March 24, 2022 16:38
@ouchadam ouchadam marked this pull request as ready for review March 24, 2022 16:39
@ouchadam ouchadam force-pushed the feature/adm/enabling-personalisation branch from 552fd97 to 899bb40 Compare March 25, 2022 10:56
@ouchadam ouchadam requested review from a team and mnaturel and removed request for a team March 25, 2022 12:14
mnaturel
mnaturel approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ouchadam
Copy link
Contributor Author

double checking with product if we want to enable the personalisation steps without the other FTUE changes

@ouchadam ouchadam mentioned this pull request Mar 28, 2022
Merged
6 tasks
@ouchadam ouchadam requested a review from mnaturel March 29, 2022 08:29
@ouchadam
Copy link
Contributor Author

@mnaturel we've decided to keep the feature disabled in favour of enabling all the onboarding steps at the same time, there's some minor changes to take into account the feature flag state in the tests

mnaturel
mnaturel approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for me but I see there are some conflicts to handle before merging.

@ouchadam ouchadam force-pushed the feature/adm/enabling-personalisation branch from d1bed4b to 0ffd20e Compare March 29, 2022 16:48
@ouchadam ouchadam changed the title FTUE - Enabling personalisation journey FTUE - Finalising personalisation journey Mar 30, 2022
@ouchadam ouchadam merged commit 9d3d574 into develop Mar 30, 2022
@ouchadam ouchadam deleted the feature/adm/enabling-personalisation branch March 30, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amshakal amshakal amshakal approved these changes

@mnaturel mnaturel mnaturel approved these changes

Assignees
No one assigned
Labels
Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ouchadam @daniellekirkwood @amshakal @mnaturel